Import - Fix warning on "Match Fields" step

[totten]

Overview

Fix PHP warning.

Before

After

No warning

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Believe it or not, the variable is spilled consistently.

[eileenmcnaughton]

that won't work :-( it will cause a fatal with smarty is secure mode :-(

I broke my brain on that particular notice so I was really excited when I saw you had tried but this isn't the answer (I concluded re-writing the js probably was)

[totten]

Yeah, the life on that flag is weird.

Is there a configuration flag that puts into the non-working mode?

[eileenmcnaughton]

/**
 * Smarty escape on output.
 *
 * This tells smarty to pass all variables through the escape function
 * unless they are piped to smarty:nodefaults (eg. {$myScript|smarty:nodefaults}
 * At this stage it should only be enabled on development sites.
 * @see https://github.com/civicrm/civicrm-core/pull/21935
 */
//if (!defined('CIVICRM_SMARTY_DEFAULT_ESCAPE')) {
//  define('CIVICRM_SMARTY_DEFAULT_ESCAPE', TRUE);
//}

[totten]

You've probably looked at this, but just to verbalize my read... When using CIVICRM_SMARTY_DEFAULT_ESCAPE, it registers a "default modifier" with CRM_Core_Smarty::escape(..."htmlall"). But it's quite zealous in applying the default modifier:

<!-- Given input... -->
{if $isCheked}

<!-- With CIVICRM_SMARTY_DEFAULT_ESCAPE=TRUE, this is compiled as... -->
<?php if (((is_array($_tmp=$this->_tpl_vars['isCheked'])) 
    ? $this->_run_mod_handler('escape', true, $_tmp, 'htmlall') 
    : CRM_Core_Smarty::escape($_tmp, 'htmlall'))): ?>

<!-- With CIVICRM_SMARTY_DEFAULT_ESCAPE=FALSE, this is compiled as... -->
<?php if ($this->_tpl_vars['isCheked']): ?>

This doesn't really make sense to me (since {if $x} isn't outputted, and escaping just complicates the conditional). Actually, it amazes me that anything works with that constraint. (But I guess most conditions work b/c 0, '', FALSE, NULL are mapped through exactly.) AFAICS, one is basically required to have {if} use the default-modifier all the time.

[eileenmcnaughton]

yeah - you can also use {if $isCheked|smarty:nodefautls}

[eileenmcnaughton]

@totten just so you know - elsewhere we use $form->addExpectedSmartyVariable - it's just that this specific one is so weird (ie the validate function is doing the assign because it is a badly written script) - that it is painful here - I'm hoping that other-Tim is coming up with a sensible script over on #23906

[totten]

$form->addExpectedSmartyVariable 🙈

May I suggest alternative #23908