dev/core#3503, dev/core#3492 Fix grant exports and relative dates #23904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This both stem from the wrong fix for https://lab.civicrm.org/dev/core/-/issues/3069 Refer to the gitlab for some famous last words....
|
Did some clicking around. It solves both issues without reintroducing the older issue. One thing is "amount requested" is not available as an export choice with selected fields, although it appears when exporting primary fields. There is "total amount" available when doing selected fields. I'm not sure if it was always that way - will try to check. |
|
Looking at a 5.45 site it seems it was the same before - you can select total_amount, but not amount_requested, but if you do primary fields then it outputs amount_requested but not total_amount. |
| $extFields = []; | ||
| foreach ($this->getSearchQueryObjects() as $obj) { | ||
| // Get Fields is ambiguous about the | ||
| $fields = method_exists($obj, 'getContactFields') ? $obj->getContactFields() : $obj->getFields(); |
|
I'm going to merge this as it has been merge ready for a few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://lab.civicrm.org/dev/core/-/issues/3503 and https://lab.civicrm.org/dev/core/-/issues/3492
They both stem from the wrong fix for https://lab.civicrm.org/dev/core/-/issues/3069
Refer to the gitlab for some famous last words....