Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second currency example #23889

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 28, 2022

Overview

This is the small part of #23870 that adds a second currency example

After

  • Extra examples are available - CAD
    image

@civibot
Copy link

civibot bot commented Jun 28, 2022

(Standard links)

@totten
Copy link
Member

totten commented Jun 29, 2022

Tried it out locally. The example loaded 👍 but I thought the title was confusing. (Same title on both examples.) Pushed a tweak. Merge on pass.

@eileenmcnaughton
Copy link
Contributor Author

Ug - that currency breakage was my last commit - because I wanted to pull the currency out of the ts() - but obviously a bit too much copy & paste

@eileenmcnaughton eileenmcnaughton merged commit 483d86a into civicrm:master Jun 29, 2022
@eileenmcnaughton eileenmcnaughton deleted the offline_cur branch June 29, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants