Move creating of nav & menu items to legacycustomsearches extension

[eileenmcnaughton]

Overview

Move creating of nav & menu items to legacycustomsearches extension

Before

Menu & navigation items for legacy custom searches declared in core code

After

Declared in the extension

Technical Details

As part of making it turn-offable....

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

FYI. We have several ways for extensions to add to the nav menu, and none of them are very good:

1. Insert during installation (hook_civicrm_install) using the api
2. Use hook_civicrm_navigationMenul
3. Use managed

They all have downsides. 1 requires manual cleanup during uninstall, and manual handling of multi-domains. 2 is non-configurable, frustrating admins who want to customize their menus. 3 works well as long as you loop through the domains in the .mgd.php. So on balance I think 3 is my favorite, and I've recently started using this pattern:

https://github.com/civicrm/civicrm-core/blob/5bee23815cd56c5214634ee7f40a1b8f52f0ac20/ext/search_kit/managed/Navigation_search_kit.mgd.php

[colemanw]

@eileenmcnaughton this looks good except for the test failures :/

[eileenmcnaughton]

@colemanw I fixed the test failure that seemed to relate - hopefully this will pass now - would be good to get a MOP so I can merge if it does since it now contacts a regen for the sql. Note that the test fails were test-only issues

[colemanw]

@eileenmcnaughton still some test issues