dev/core#2983 - Make static function static - AJAX::caseDetails()

[demeritcowboy]

Overview

Related to https://lab.civicrm.org/dev/core/-/issues/2983

Deprecated function: Non-static method CRM_Case_Page_AJAX::caseDetails() should not be called statically in CRM_Core_Invoke::runItem() (line 285 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php)

Also an error about end_date missing when there is no end_date. And the html is broken when there is one.

Before

1. Because ajax swallows it, you need to first turn off popups at administer - customize - display prefs, or install the loudnotices extension and then view the error 500 response in the network tab.
2. Create a case.
3. Run the case details civireport.
4. Click on the subject. (Because we turned off popups, this is going to seem like it's a useless feature, and there's an argument that even with popups on it's not that useful since normally you would add columns to the report, but just act like everything is fine.)
5. Now go to any other civi page. Now the error appears.

After

Better

Technical Details

Comments

The only other places this function is used is as described in the lab ticket, but other than handling the same error I'm not addressing the larger questions here.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks!