Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty date token gracefully #23827

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Handle empty date token gracefully

Before

Error on date tokens that are empty

After

Handled

Technical Details

@totten this is the issue you hit - I will put up for 5.50 too - since the fix is safe & sensible & this could pop up as a hard-to-find regression in various workflows

Comments

@civibot
Copy link

civibot bot commented Jun 17, 2022

(Standard links)

@civibot civibot bot added the 5.51 label Jun 17, 2022
@totten
Copy link
Member

totten commented Jun 17, 2022

Yup, this is pretty close to my earlier exploration, and I've confirmed (r-run) that it fixes an error when previewing a message.

@totten totten merged commit 7aa8fea into civicrm:5.51 Jun 17, 2022
@eileenmcnaughton eileenmcnaughton deleted the empty_date branch June 17, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants