Fix breakage in message preview on workflow contributions

[eileenmcnaughton]

Overview

Fix breakage in message preview on workflow contributions

Before

Failure to render message preview for offline contributions in message admin ui

After

Technical Details

There is a sort-of regression fix in here - isShowLineItems was being assigned in reverse - but I don't think we encouraged that tpl change so probably no-one will be much affected - but I can switch to the rc if preferred. Perhaps there is a case for that since it will be the ESR & we will be stuck with it for longer -

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Update - switched to the rc because of the showLineItems issue - which would affect new sites & is technically a regression so should be in the rc (& possibly in tomorrow's drop)

[totten]

I tried this out a couple ways - ie (1) in the web UI, (2) by doing some additional work to enable phpunit-testing for this example (draft branch). In both cases, confirmed that it fixed the error.

However, on my local, the message-preview doesn't show the data-table ("Contribution Information"). I suppose {if $amount} is returning is false. This probably is distinct from the fix in this PR - so we can leave that for another PR.

[eileenmcnaughton]

thanks @totten