Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear what "record refund" form does #23792

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

mattwire
Copy link
Contributor

Overview

It was not clear to me if the "Record refund" form was capable of talking to payment processors etc. - it's not.

Before

Not clear as to whether this form might talk to a payment processor or not.

After

Clear:
image

Technical Details

Comments

@adixon @JoeMurray @eileenmcnaughton Just wanted to ping you here to check my assumption is correct? Eg. IATs doesn't have any overrides/hooks for that form that actually allows a refund to be requested for example?

@civibot
Copy link

civibot bot commented Jun 14, 2022

(Standard links)

@civibot civibot bot added the master label Jun 14, 2022
@adixon
Copy link
Contributor

adixon commented Jun 14, 2022

Yeah, worth making that clearer for sure. We've definitely been on side of not hooking into refunds at iATS for reasons of risk, but I'm not sure that's always true for other payment processors - I had thought you were working on something that allowed refunds in stripe via the civicrm web interface?

@mattwire
Copy link
Contributor Author

@adixon Yes, I have a refunds UI via mjwshared - see https://docs.civicrm.org/mjwshared/en/latest/refunds/ but it doesn't use this form and it confuses me and clients who are using my refund UI. So this text helps clarify the difference.

@eileenmcnaughton
Copy link
Contributor

seems fine - we can just make the text conditional if we add processor support

@eileenmcnaughton eileenmcnaughton merged commit ec3ec6e into civicrm:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants