FiveFiftyOne - Enable snapshots for data modified data #23783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before ------ The 5.51.alpha upgrade modifies a some data-structures (`civicrm_mapping_*`, `civicrm_queue`), but it doesn't take any snapshots. After ----- It does snapshots. Comments -------- Both tables should generally be quite small. Strictly, the `civicrm_mapping_*` updates are more in-place modifications, so that's more important. The `civicrm_queue` changes are only adding new columns. But the table is so small - it doesn't hurt. I suppose one could argue that these particular fields aren't likely to have problems - but it's important to get in the habit of enabling snapshots so that we have them when they do matter.
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
The 5.51.alpha upgrade modifies a some data-structures (
civicrm_mapping_*,civicrm_queue),but it doesn't take any snapshots.
After
It does snapshots.
Comments
Both tables should generally be quite small.
Strictly, the
civicrm_mapping_*updates are more in-place modifications,so that's more important. The
civicrm_queuechanges are only adding newcolumns. But the table is so small - it doesn't hurt.
I suppose one could argue that these particular fields aren't likely to have
problems - but it's important to get in the habit of enabling snapshots so
that we have them when they do matter.