fix disableUSPS since import running in separate context of Queue.

[darrick]

Overview

I recall discussing getting rid of this option. So, setting it to disabled as default I think was better then having it accidentally run. I also added a notice about how it violates the USPS terms of service.

https://www.usps.com/business/web-tools-apis/address-information-api.htm

The Address Validation APIs can be used in conjunction with USPS SHIPPING OR MAILING SERVICES ONLY. The Address API must only be used on an individual transactional basis, i.e. not batch processing or cleansing of a database, but as a customer enters the information into a form on a website. Failure to comply with these terms and conditions can result in termination of USPS API access without prior notice.

Before

disableUSPS was being ignored as importing was moved to a separate context.

After

disableUSPS is being set for each batch.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[darrick]

@eileenmcnaughton I have no clue how I got back to here. But it does look like it's now just one commit to 5.51.

[eileenmcnaughton]

nice

[eileenmcnaughton]

nice - those tests will need the array key added so as not to fail

[darrick]

@eileenmcnaughton Can you point me in the right direction for what needs to happen with the tests?

[eileenmcnaughton]

It's these arrays in the test - you need to add in the extra property to avoid e-notices

[eileenmcnaughton]

probably everywhere you find doGeoCode

[darrick]

@eileenmcnaughton Found it right after I commented by looking up the old failed test. I'm curious now if there is a way to have jenkins abandon a test. As it's running four or five on my last commits.

[eileenmcnaughton]

I think I possibly CAN cancel jenkins jobs - but mostly we just wait it all out

[darrick]

@eileenmcnaughton

So, I did the following and that seemed to work. Thanks for all that. But, do I do the git pull just periodically to keep things on track and then the fetch, rebase, push -f to squash?

  508  git pull --rebase upstream 5.51
  509  git status
  510  git fetch
  511  git rebase -i upstream/5.51
  512  git push -f

[eileenmcnaughton]

yeah - I do git pull --rebase all the time - just to keep it fresh

[eileenmcnaughton]

yay - all passed