dev/financial#199 - Add failing test to demonstrate the problem

[demeritcowboy]

Overview

Failing test for https://lab.civicrm.org/dev/financial/-/issues/199: Additional Details section when editing recurring contributions won't load.

Before

Won't load - spinning icon.

After

Still doesn't, but adds proof. This should output:

CRM_Contribute_Form_UpdateSubscriptionTest::testAdditionalDetails
Exception: PEAR_Exception: "QuickForm Error: nonexistent html element"
 * ERROR TYPE: HTML_QuickForm_Error
 * ERROR CODE: -3
 * ERROR MESSAGE: QuickForm Error: nonexistent html element
 * ERROR MODE: 16
 * ERROR USERINFO: Element 'contribution_status_id' does not exist in HTML_QuickForm::getElement()

Technical Details

There is no contribution_status_id, so trying to freeze() it throws an error. A simple fix would be to check elementExists() first, but feels awkward.

Comments

In real life recurring creates a mirror contribution record with a status of "Template". Updated the trait to do that.

There's also a problem with status_id when you save. Haven't addressed yet.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Just noting that I think we should unfreeze the amount on the edit-recurring for single line items (restore functionality) but we need to make it so the template contribution is updated when the civicrm_contriution_recur.amount is altered (the api/bao should reject changes if more than one line item)

[demeritcowboy]

At the moment I'm just trying to deal with errors for the status_id field. I'm going to convert this into a failing test.

[mattwire]

Fix here #23786

[eileenmcnaughton]

test this please