Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#3513 Remove 'done' from sumary/import monitoring page #23766

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

dev/core#3513 Remove 'done' from sumary/import monitoring page

See dev/core#3513 for why it's confusing

https://lab.civicrm.org/dev/core/-/issues/3513

@civibot
Copy link

civibot bot commented Jun 11, 2022

(Standard links)

@civibot civibot bot added the master label Jun 11, 2022
@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.51 June 11, 2022 03:01
@civibot civibot bot added 5.51 and removed master labels Jun 11, 2022
@demeritcowboy
Copy link
Contributor

demeritcowboy commented Jun 11, 2022

I'm personally fine with removing the button, but noting that I think such buttons are there because most people feel like there should be a button and it's a common pattern in civi to have such buttons.

🤷‍♂️

It would be fun if there were two buttons: Done and "Not Done", and the latter would just do nothing (or both would do nothing).

@demeritcowboy
Copy link
Contributor

Noting also that you need to remove this line too otherwise you get

Notice: Undefined index: buttons in ...\templates_c\en_US\%%ED\ED7\ED78F5CC%%formButtons.tpl.php on line 38

See dev/core#3513 for why it's confusing
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy - done

@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label Jun 11, 2022
@totten totten merged commit a930904 into civicrm:5.51 Jun 13, 2022
@eileenmcnaughton eileenmcnaughton deleted the cont_up branch June 13, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.51 merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants