Add integer validation to import #23753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add integer validation to import
Before
passing in a non-integer to an integer field is not rejected in
validate
/getTransformedValues
- it probably bounces later on thoughAfter
Actively validate integers (once fields with option values have been resolved) in
validate
/getTransformedValues
Technical Details
I spotted that there used to be a security issue with the checks on contact id - that was fixed but it made me think we should harden this now while there is QA attention on imports.
Comments