Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integer validation to import #23753

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 10, 2022

Overview

Add integer validation to import

Before

passing in a non-integer to an integer field is not rejected in validate/getTransformedValues - it probably bounces later on though

After

Actively validate integers (once fields with option values have been resolved) in validate/getTransformedValues

Technical Details

I spotted that there used to be a security issue with the checks on contact id - that was fixed but it made me think we should harden this now while there is QA attention on imports.

Comments

@civibot
Copy link

civibot bot commented Jun 10, 2022

(Standard links)

@civibot civibot bot added the master label Jun 10, 2022
@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.51 June 10, 2022 11:14
@civibot civibot bot added 5.51 and removed master labels Jun 10, 2022
@eileenmcnaughton
Copy link
Contributor Author

@totten @seamuslee001 @demeritcowboy @colemanw can we merge this asap - it's a security hardening & if we don't get it in for rc testing I might bottle out - if it DOES cause issues we can revert

@colemanw colemanw merged commit 8ada309 into civicrm:5.51 Jun 14, 2022
@colemanw colemanw deleted the import_validate_int branch June 14, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants