Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unrelease regression - malformed MapField without skipColumnHeaders #23744

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fix unrelease regression - malformed MapField without skipColumnHeaders #23744

merged 1 commit into from
Jun 10, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 9, 2022 •
edited
Loading

Overview

Fix unrelease regression - malformed MapField without skipColumnHeaders

Before

Do NOT select First row contains column headers

image

image

After

image

Technical Details

I tested this on membership - but they all use the same code now

Comments

@civibot
Copy link

civibot bot commented Jun 9, 2022

(Standard links)

@civibot civibot bot added the master label Jun 9, 2022
@eileenmcnaughton
Copy link
Contributor Author

@colemanw can you OK this - it is a regression

@eileenmcnaughton
Copy link
Contributor Author

Fail unrelated - fix is in #23751

@eileenmcnaughton eileenmcnaughton merged commit aaddba5 into civicrm:master Jun 10, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_csv branch June 10, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw