Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3483: parent_id not always available as index #23730

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Issue #3483: parent_id not always available as index #23730

merged 1 commit into from
Jun 8, 2022

Conversation

herbdool
Copy link
Contributor

@herbdool herbdool commented Jun 8, 2022

Fixes https://lab.civicrm.org/dev/core/-/issues/3483

Overview

Don't need parent_id when deleting a note, even if it's a child note aka "comment". In fact, it's not even available. So check if it is empty or not.

@civibot
Copy link

civibot bot commented Jun 8, 2022

(Standard links)

@colemanw
Copy link
Member

colemanw commented Jun 8, 2022

Merging this is a no-brainer, even though it doesn't solve every problem in that entity, it solves one of them!

@eileenmcnaughton eileenmcnaughton merged commit 1c7df33 into civicrm:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants