Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution import - simplify error handling #23714

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Contribution import - simplify error handling

Before

Lots of handling, call to summary - but this has been removed from the other imports as it validates the rows - but that has already been done by this point, and the table has been updated with the results - so the ones that failed will not load

After

Rely on the catch block, removed summary call

Technical Details

Comments

@colemanw should be straight forward

@civibot
Copy link

civibot bot commented Jun 7, 2022

(Standard links)

@civibot civibot bot added the master label Jun 7, 2022
@colemanw colemanw merged commit 44e777a into civicrm:master Jun 7, 2022
@colemanw colemanw deleted the import_conts branch June 7, 2022 23:59
@eileenmcnaughton eileenmcnaughton restored the import_conts branch June 8, 2022 00:55
@eileenmcnaughton eileenmcnaughton deleted the import_conts branch April 19, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants