dev/core#2325 Fix handling of seconds on import

[eileenmcnaughton]

This addresses an issue where the following date time has the time component
stripped

2012-12-12 07:12:56

Without the seconds - ie

2012-12-12 07:12

Note that an assert could be added to check the activity here once that PR is merged (and that this can't be tested in the import context until it is as there is other breakage)

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

The patch looks good. r-run passed on local. Merging now.

[demeritcowboy]

I had a couple problems testing this. First is it didn't run because Error: Call to undefined method CRM_Activity_Import_Parser_Activity::setFieldMetadata() in CRM_Import_Parser->getMappedFieldLabel() (line 1742 of ...\CRM\Import\Parser.php). Second is this regex will accept something like 2020-01-02 12:1459 as a datetime (although I also wanted to see if it even matters because of the code below it). And then third does it actually import the seconds properly into the db? At first glance the code looked like it still drops it and then puts 00.

[eileenmcnaughton]

@demeritcowboy there is an open PR that fixes the activity import

[eileenmcnaughton]

But yeah - I think this needs a bit more work to be sure what is happening

[eileenmcnaughton]

@demeritcowboy

with #23707 applied it still doesn't import the seconds but it stops dropping the rest of the time

And without