Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Make loading placeholders configurable #23702

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jun 6, 2022

Overview

This allows the admin to control how many (if any) skeleton results are shown during ajax loading.

It also lightens the colors to make the animation a bit more subtle.

Before

Five placeholders always shown. Animation was reportedly a bit distracting.

After

Colors lightened to be less distracting. Configurable number, or can be disabled completely.
image

This allows the admin to control how many (if any) skeleton results are shown
during ajax loading.

It also lightens the colors to make the flashing a bit more subtle.
@civibot
Copy link

civibot bot commented Jun 6, 2022

(Standard links)

@civibot civibot bot added the master label Jun 6, 2022
@clarkac1
Copy link

clarkac1 commented Jun 6, 2022

I tested this 6/6/22 and, while it's hard to see the flashing lines because of the speed of the test system, it appears to work just fine. When this is in a nighty build I will download and test on a shared host which is much slower and where the visuals will be much more apparent.

@eileenmcnaughton eileenmcnaughton merged commit 7f17854 into civicrm:master Jun 7, 2022
@eileenmcnaughton eileenmcnaughton deleted the loadingPlaceholders branch June 7, 2022 00:23
@clarkac1
Copy link

clarkac1 commented Jun 7, 2022

Tested again, now I have read the description properly! Downloaded & installed 5.51.alpha1-202206061704 on a shared host because it's slow enough to see the flashing lines. It works as described, although I have to 'Cleanup caches...' in between each change to see the correct result (which is fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants