Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add not-yet-used function to allow the import to run in static (queue) context #23691

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Add not-yet-used function to allow the import to run in static (queue) context

This adds the import function from #23669 - so that that PR not being merged doesn't hold up fixes on the other classes. Note that this part (or any part as far as I know) of that PR is not under question - I think the discussion is all centred on the follow on steps to be worked on once that PR is merged.

Before

  • the different import classes all use the same type_id when creating user jobs

After

Different one per import

Technical Details

At this stage the list is still very much static - it probably will be hookable or similar in future

Comments

@civibot
Copy link

civibot bot commented Jun 4, 2022

(Standard links)

@civibot civibot bot added the master label Jun 4, 2022
I left it as just contact to start with - but as I've gone further it's clear
we need a type for each import - best done now
This is required both for the queue fix and for QA fixes on the import classes.
@seamuslee001 seamuslee001 merged commit a77d014 into civicrm:master Jun 5, 2022
@seamuslee001 seamuslee001 deleted the contact_type branch June 5, 2022 22:52
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants