Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#3481 - Don't translate css classes #23686

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

demeritcowboy
Copy link
Contributor

Overview

https://lab.civicrm.org/dev/core/-/issues/3481

Primary email is not bolded on contact summary when using non-english

Before

Untitled2

After

Untitled3

(Italian isn't a good example since it doesn't have "primary" translated in the .po, but I'd already taken the screenshot before noticing.)

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jun 3, 2022

(Standard links)

@civibot civibot bot added the master label Jun 3, 2022
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@colemanw
Copy link
Member

colemanw commented Jun 3, 2022

🤦

@colemanw colemanw merged commit da49f1a into civicrm:master Jun 3, 2022
@demeritcowboy demeritcowboy deleted the primary-ts branch June 3, 2022 21:55
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants