[Import] [Contribution] Cleanup templates & form variables, following contact pattern

[eileenmcnaughton]

Overview

Cleanup templates & form variables, following contact pattern

Before

When doing an contribution import if you go forwards to the MapField screen and then BACK to the DataSource screen you get a fatal error

After

Fixed - in addition I have applied a bunch of shareable techniques from the contribution import to help align the code.

Technical Details

This came about because things were reviewed & merged in orders other than they were developed in. I wasn't entirely surprised - hence I have been doing r-run testing on what is merged

I suspect other imports will be impacted but I will test them one by one & put up PRs - it seems that for review in this area a lot of code area but a small r-run testing surface area is what reviewers want. This DOES have changes that affect contact too - I have r-run against both - but note the contact changes CAN be tested & merged separately via #23680

It would be nice to extend the queue usage to this - I need to work through the return codes for pledge, soft credit to sort that out

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@monishdeb if this passes in time for the end of your day woudl you take a look - it was causing some test fails & those were because the test was testing the old functions - which I think are obsolete - but I pulled it back to not changing those

Without this there is a significant error in the Contribution import (and maybe other) form flow (master only) - I will keep testing the others to get us in good state for the rc

[eileenmcnaughton]

@colemanw I just rebased this over the one you merged - it was passing & I expect it will again - it fixes a regression that will likely affect other imports - so I'm gonna work on them once this is merged

[colemanw]

Cool, thanks @eileenmcnaughton