Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv3 - Fix regression in handling chained calls with sequential #23672

Merged

Conversation

seamuslee001
Copy link
Contributor

…sage

Overview

This fixes a bug caused by the recent security release which forced any chained api calls to be outputted in sequential even if not requested.

Before

if Sequential was missing from the array or included the result was forced into a sequential array in the chain

After

sequential is correctly managed

@KarinG @demeritcowboy can you test this on your webform stuff?

@civibot
Copy link

civibot bot commented Jun 2, 2022

(Standard links)

@civibot civibot bot added the master label Jun 2, 2022
@demeritcowboy
Copy link
Contributor

can you test this on your webform stuff?

Yes! As of a few weeks ago there's this handy new option to test against a core PR:
Untitled3

@demeritcowboy
Copy link
Contributor

demeritcowboy commented Jun 2, 2022

Locally just doing a similar cv call to what uscounties does with this PR applied gives the right output.

Should be against 5.50 though.

@seamuslee001
Copy link
Contributor Author

@demeritcowboy see #23673 for the 5.50 version, this one is the analogous of the RC PR

@totten totten changed the title [REF] Fix issue where forceing sequential broke webform API chained u… APIv3 - Fix regression in handling chained calls with sequential Jun 2, 2022
@totten
Copy link
Member

totten commented Jun 2, 2022

FWIW, there is some test coverage around the recent chaining fix in CRM_Utils_RestTest. It would be good to add some coverage for this use-case (and RestTest should be a decent template).

However, considering that this is a very recent regression, that won't block merging the present PR.

@seamuslee001 seamuslee001 merged commit 6361ad9 into civicrm:master Jun 2, 2022
@seamuslee001 seamuslee001 deleted the fix_sequential_enforcement branch June 2, 2022 23:39
omarabuhussein added a commit to compucorp/civicrm-core that referenced this pull request Jun 3, 2022
omarabuhussein added a commit to compucorp/civicrm-core that referenced this pull request Jun 3, 2022
scardinius added a commit to caltha-eu/civicrm-core that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants