Contact Import cleanup - includes fixes to contact matchine #23666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the e-notice identified here civicrm#23643 (comment) I believe the bug report in that thread was a variant of the e-notice. Ie the import() function was failing to catch an exception & it was bubbling up to run() While there is no support currently for calling import() outside of run() - the intent is to replace run() with something more sane - which WILL be callable from the outside (likely via api). The right behaviour for import() is to catch all errors
Note this code is no longer called by contact import, and the others do not pass in relationship key - so we can remove rather than fix
This is now only checking booleans in a way that duplicates getTransformedValue
No point having a separate line function
|
(Standard links)
|
284315f to
783f110
Compare
61a3c3f to
0fbb860
Compare
0fbb860 to
f363505
Compare
|
Thanks @mlufty as discussed elsewhere - this is a big code tidy up but @MegaphoneJon has said he can put some QA resources to the rc & @darrick is also actively involved in testing & reviewing There are around 400 lines of code left that I think do nothing.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Contact Import cleanup - includes fixes to contact matchine
I thought I'd pull all the various cleanups into one PR & see if they play nice together (also good for r-run testing)
However, the ones that are non-cleanup are #23660 and #23665 - which, it turns out, don't conflict
A good portion of the others are very straight forward
Before
After
Technical Details
Comments