Remove legacy calls to civicrm_error, unpack return

[eileenmcnaughton]

The function can only return an array or a BAO object

Overview

Remove legacy calls to civicrm_error, unpack return

Before

createContact only ever returns

• an array if a duplicate is found
• a BAO object if not

But the code keeps 'checking out' the array with an api function that should not be used

In addition the array ALWAY contains ['error_message']['params'] so the handling for when it doesn't is unreachable

After

poof

Technical Details

Comments

I've continued on with the further cleanups this allows in #23635 - as it starts to get hard to read after this point

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Great cleanup!

[eileenmcnaughton]

thanks @colemanw - it conflicts with #23626 - I'd really rather rebase this over than than the revese as there are several other PRs that are built on top of that...

[eileenmcnaughton]

Oh well - this has passed - I'll rebase the other