Print report or export report if user have access report permission

[pradpnayak]

Overview

https://lab.civicrm.org/dev/core/-/issues/2540

Before

when disabling the “access Report Criteria” permission, the "Print report" and "Print to PDF" functions on a report appear, but do not function.
After

when disabling the “access Report Criteria” permission, the "Print report" and "Print to PDF" functions on a report appear to work

Technical Details

When “access Report Criteria” is not set to user role, $this->_params['fields'] is empty hence $this->_noFields is not set causing $this->_params to get over-ridden with formvalues stored in the database, hence task parameter is lost is $this->_params which is used to set report mode in processReportMode().

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[pradpnayak]

An alternate PR for this fix is #23617

[adevapp]

Tested and works.

[eileenmcnaughton]

@pradpnayak @yashodha do either of you have a preference between the 2 - I see @adam-devapp has tested this which puts it ahead :-)

[eileenmcnaughton]

I guess since this has been UI tested & the other has ?? that's a vote for this one .... @mlutfy I have some memory of you engaging in something related to this in the past?