Afform - Implement client-side validation of required fields #23604
Conversation
|
(Standard links)
|
| @@ -89,6 +92,10 @@ | |||
| } | |||
|
|
|||
| this.submit = function() { | |||
| if (!ctrl.ngForm.$valid) { | |||
There was a problem hiding this comment.
@colemanw just wondering if we need to be able to customise the alert here and does this work on front ends? I can't recall if CRM gets loaded correctly on front end
There was a problem hiding this comment.
I am not sure if this logic will ever be invoked as required validation happens at field level.
| @@ -89,6 +92,10 @@ | |||
| } | |||
|
|
|||
| this.submit = function() { | |||
| if (!ctrl.ngForm.$valid) { | |||
There was a problem hiding this comment.
I am not sure if this logic will ever be invoked as required validation happens at field level.
|
It's working for fields from the standard entities but not for fields from my custom entity. The fields show as required on the builder page but not on the display page. To test with a custom entity, see https://lab.civicrm.org/dev/core/-/issues/3728 |
|
I've rebased this @eileenmcnaughton @kurund |
|
Below is the sample form with all the fields configured as required in the Formbuilder. However, I was able to submit the form by filling only data in the above screenshot. |
|
It looks like "required" param is missing in field definition for 'joins'. You can check the generated code. Hence, I the email validation is failing. |
93ad318 to
9004e91
Compare
|
@kurund I've fixed setting default required value for e.g. Email joins. |
Overview
This is (so far) a client-side only implementation of required field validation for Afforms.
See https://lab.civicrm.org/dev/core/-/issues/3137
Before
Required fields not required.
After