[Import] Cleanup Contribution flow - esp with regards to soft credits

[eileenmcnaughton]

Overview

[Import] Cleanup Contribution flow - esp with regards to soft credits

This builds on #23586 and does significant clean up on handling for soft credit imports

Before

• multiple arrays need to be constructed to construct CRM_Contribute_Import_Parser_Contribution
• When importing a soft credit it says you can match on email - however this ONLY works if your dedupe rule is configured to match on email along

After

• most of the arrays are removed (working on the last one) - in favour of user_job_id
• since we are saying the email is used to match & we don't have any other fields it now does a simple lookup on email

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Closing this for now - I want to check something & also need the other one merged first

[eileenmcnaughton]

Actually I was wrong - the thing I was thinking about was fine

[eileenmcnaughton]

test this please

[seamuslee001]

@eileenmcnaughton Fatal error: Cannot redeclare CRM_Contribute_Import_Parser_Contribution::getMappedRow() in CRM/Contribute/Import/Parser/Contribution.php on line 458

[eileenmcnaughton]

argh - lost in the rebasing - I will do again - it would be good to get this one merged first though - #23637 (it adds functions not yet called to help with conflicts like this)

[eileenmcnaughton]

argh - that one has a lock file snuck in - re-doing all the prs

[eileenmcnaughton]

It will also need rebasing once #23636 is merged - but the sooner the better for that one as I can rebase this & a couple of other PRs

[eileenmcnaughton]

@monishdeb - Coleman merged a bunch - if you get to it it would be great to see this merged & the membership one - as time allows

[monishdeb]

• General standards

  • (r-explain) PASS
  • (r-user) PASS
  • (r-doc) PASS : I think PR description explains in detail
  • (r-run) PASS: I have tested the patch in the test-build generated. Verified the with contribution match with existing contact email. And then with external identifier. Works fine

• Developer standards

  • (r-tech) PASS
  • (r-code) PASS
  • (r-maint) PASS
  • (r-test) PASS

[eileenmcnaughton]

Yay - thanks @monishdeb