dev/core#3463 - CiviMail - prefer frontend_title from group for maili… #23570
Conversation
|
(Standard links)
|
466ac8d to
90d30f1
Compare
|
@ufundo this makes sense to be but you need to check the style warnings https://test.civicrm.org/job/CiviCRM-Core-PR/49060/checkstyle/ |
90d30f1 to
1a1be8d
Compare
CRM/Mailing/BAO/Mailing.php
Outdated
| ->addWhere('mailing_id', '=', $this->id) | ||
| ->addWhere('entity_table', '=', 'civicrm_group') | ||
| ->addWhere('group_type', '=', 'Include') | ||
| ->setLimit(25) |
There was a problem hiding this comment.
I would remove this limit 25
There was a problem hiding this comment.
I left it in thinking 'if you have more than 25 groups in your mailing, this token is going to be a mess' but yes that was probably not a good thought! Have removed now.
|
@ufundo I agree with this enhancement. The 25 limit looks like it snuck in and suggested this should be removed. I have minor PTSD from this option.
|
1a1be8d to
b9f2127
Compare
|
@agileware-justin - shall I give this merge-on-pass now? |
|
@eileenmcnaughton let me test this on DEV and confirm OK. |
|
Thanks @agileware-justin ! |
Existing group token outputInternal group title is output for the {mailing.group} token
|
Patch applied, group token outputWith the patch applied, public group title is output, if set for the {mailing.group} token. Otherwise will output the group title.
|
|
@eileenmcnaughton that's a pass from me. |
|
@agileware-justin thanks - I was too mesmerised by your screenshots to be able to figure out if they were right or not :-) Nice to see some legacy code pattern removed too |
|
Screenshot updated. Agileware ref: CIVICRM-1990 |
|
lol! |
…ng.group token
Overview
Implementation for https://lab.civicrm.org/dev/core/-/issues/3463
Before
{mailing.group} token in CiviMail always uses the
titlefield for each of the groups in the mailing.After
Uses the
frontend_titlefield for any groups in the mailing where this is set.Technical Details
I was slightly worried about issues with permissions / bootstrapping. I've test sending scheduled mailings with a cron user with the sysadmin-docs-recommended cron permissions of View all contacts, Access CiviCRM, Access CiviMail and seems to work ok :)