Remove do-nothing deprecated line

[eileenmcnaughton]

Overview

Remove do-nothing deprecated line

Before

This line was originally deprecated under the believe it was no longer needed. Later a comment was added to point out it it is still hit - 2 things can be true at once.

The line IS hit and is a blocker to adding test cover. However, it is also unnecessary - the line is in formatCommonData and is hit when iterating through a relationship key within the main contact params array & causes it to call itself to process that key - however, the line is ALSO called later with just the relationship data - achieving the same thing that the nested call does, but without the deprecated warning & extra loop

After

poof

Technical Details

I have tests locally covering this but as this is the blocker to those tests, not the focus of them - I need to merge this first

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).