Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable code #23551

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove unreachable code

Before

The last 2 conditions would only be true if the first is & it's an ELSE construct....

image

After

image

Technical Details

Since it's broken I'm just removing it - the code it DOES hit is kinda doing the same thing - since it does compare against option values valid for the field hence no-one noticed it....

Comments

@civibot
Copy link

civibot bot commented May 23, 2022

(Standard links)

@civibot civibot bot added the master label May 23, 2022
@eileenmcnaughton
Copy link
Contributor Author

@monishdeb are you able to merge this - I think it's a no brainer since the first if means it will never get to the last 2 elseifs

@monishdeb
Copy link
Member

Agree, just to ensure I double-checked the code, and seems ok to remove the unreachable code. Hence merging.

@monishdeb monishdeb merged commit 0311312 into civicrm:master May 24, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_no_go branch May 24, 2022 07:04
@eileenmcnaughton
Copy link
Contributor Author

thanks @monishdeb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants