Clean up function signature

[eileenmcnaughton]

Overview

Minor simplification - rather than pass in $customFields and use it to get $fieldMetaData = $customFields[$customFieldID] - just pass in $customFields[$customFieldID];

Before

After

Technical Details

• I moved the check for the field being there to being before calling the function
• I re-ordered the input fields to reflect the fact that some might be phased out in time
• Most of the change is just using $metadata directly

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks good to me