Cleanup sql query #23512
Merged
Cleanup sql query #23512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
On digging into this query I found that is uses protected words like value & count so I have fixed the query to no longer use those & re-formatted to add comments. I suspect the actual fix might need to sit around pending community input so I think it is good to get this tidy up merged to make it all clearer
bd1ddd4 to
30d6c82
Compare
|
@seamuslee001 this is nfc - towards https://lab.civicrm.org/dev/core/-/issues/1197 |
|
civibot, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On digging into this query I found that is uses protected words like value & count
so I have fixed the query to no longer use those & re-formatted to add comments.
I suspect the actual fix might need to sit around pending community input so I think it is good to
get this tidy up merged to make it all clearer