Remove mealy-mouthed isset
check from params['id']
#23505
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove isset to clarify that
$params['id']
is either a value or NULLBefore
To get to this point
the code must pass through this try -catch
so we
a) know the array key exists
b) know that it is either NULL or an integer per the return values of
$this->lookupContactID
After
Checking for truthy-ness makes it clear that if there is a value it is meaningful (not an empty string for example)
Technical Details
Comments