[Import] Remove silly param

[eileenmcnaughton]

Overview

[Import] Remove silly param

I've finally solved the mystery of this parameter - the crux of this change is this

Before

$relationships is an array of available relationships - in format like
['5_a_b' => 'Employer Of']

It is metadata passed into the custom data function and the reason turns out to be to confirm that the sub-array within $params 'really really' is a relationship type sub-array. In actual fact I'm pretty sure the check to see if it is an array with a 'contact_type' key is enough to confirm it

It also handles the impossible situation where the key is the relationship label instead - maybe once that was possible

After

The additional check is now to see if the string ends in a_b or b_a instead

Technical Details

This is the custom data validation routine so not a place to check the validity of the relationship

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Down with sillyness!