Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import] Add tests for contact type & contact subtype handling #23475

Merged
merged 1 commit into from
May 18, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[Import] Add tests for contact type & contact subtype handling

Before

No tests to cover what happens when you update a contact with an external identifier match and
a) a different contact type or
b) a different contact subtype

After

Tests lock in what happens which turns out to be
a) no update if the contact type doesn't match
b) subtype is replaced on update

Technical Details

There is no real change to the non-test code. I had to add an early return due to an enotice but the code would otherwise return the same value here

Comments

@civibot
Copy link

civibot bot commented May 17, 2022

(Standard links)

@civibot civibot bot added the master label May 17, 2022
@colemanw colemanw merged commit 77e31fd into civicrm:master May 18, 2022
@colemanw colemanw deleted the imp_fold branch May 18, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants