[Import] Unpack the weird wild error return #23474

eileenmcnaughton · 2022-05-17T04:32:45Z

Overview

This unravels what is happening in a bit of deprecated code - I captured the array that is created as a result of the weird push & pop routine

It has always been a mystery to me what all that array pushing & popping resulted in

Return array specifically coded to have the same effect & be explicit

Turns out test cover in CRM_Member_Import_Parser_MembershipTest.testImport

civibot · 2022-05-17T04:32:47Z

(Standard links)

If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

civibot bot added the master label May 17, 2022

eileenmcnaughton force-pushed the import_dep branch from 68666e3 to bb1f622 Compare May 17, 2022 04:33

eileenmcnaughton changed the title ~~[Import] Unpack the weird error return~~ [Import] Unpack the weird wild error return May 17, 2022

eileenmcnaughton force-pushed the import_dep branch from bb1f622 to 68970ec Compare May 17, 2022 06:07

eileenmcnaughton mentioned this pull request May 19, 2022

[Ref] [Import] Cleanup function return #23511

Merged

eileenmcnaughton force-pushed the import_dep branch from 68970ec to 2b21966 Compare May 24, 2022 06:32

[Import] Unpack the weird error return

972906b

eileenmcnaughton force-pushed the import_dep branch from 2b21966 to 972906b Compare May 25, 2022 04:27

colemanw merged commit d2256e5 into civicrm:master May 29, 2022

colemanw deleted the import_dep branch May 29, 2022 15:46