Dashboard - Efficiency tweak

[colemanw]

Overview

Minor performance boost for Angular-based Dashboard page.

Technical Details

Use static binding for non-changing values.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

r-run still seems to work - how did you identify the need for this?

[totten]

Looks sensible to me. I suspect it's identified based on general/systemic preference rather than a specific usage/measurement.

The {{::ts()}} always seems look a good idea. The {{:: $ctrl.foo}} seems like it might be a little more context-dependent? But looks safe in this case. (The dashboard doesn't include any mechanism for editing or refreshing the dashlet metadata.)

[eileenmcnaughton]

@totten so we should always put those :: before ts in angular?

[totten]

@totten so we should always put those :: before ts in angular?

(Reconsiders) Well... 95% of the time...

The proper question is whether the value will change during the page-view:

• If the value foo will not change, then output with {{:: foo}}
• If the value foo will change, then output with {{ foo }}. (This requires more plumbing to watch for changes. It's not necessarily expensive in isolation, but it can add-up if you have hundreds on a page.)

Most ts() expressions will not change -- they're just simple messages like ts('Continue'). But sometimes you have params like ts("Hello %1", {1: name}) which might change. (A quick-and-dirty grep for ts( in ang/**.html suggests the split is roughly 95% vs 5%.) For the 5%, it's a judgment-call.

[colemanw]

Right, the :: at the beginning of the expression tells Angular to evaluate it only once (or, techincally, evaluate it every digest cycle until it resolves to something other than undefined and then stop).

If you omit the :: then Angular will evaluate it every digest cycle, using up the client's cpu needlessly if the value never changes.