Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST ONLY] APIv4 - Remove unused extras from ConformanceTest #23410

Merged
merged 1 commit into from
May 9, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 9, 2022

Overview

Cleans up the APIv4 Conformance test to remove the not-useful TransactionalInterface (broken because this test creates custom data) and the unused OptionCleanupTrait (which never called its tearDown method so did nothing).

@civibot
Copy link

civibot bot commented May 9, 2022

(Standard links)

@civibot civibot bot added the master label May 9, 2022
@colemanw colemanw force-pushed the api4ConformanceTestBase branch from 9e2ac1b to d0f6424 Compare May 9, 2022 15:45
@colemanw
Copy link
Member Author

colemanw commented May 9, 2022

Merging. (it's just unit tests, and they pass)

@colemanw colemanw merged commit 1399d56 into civicrm:master May 9, 2022
@colemanw colemanw deleted the api4ConformanceTestBase branch May 9, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant