(REF) Importer - Remove unused parameters. Simplify signature.

[eileenmcnaughton]

Overview

[Import] Fix database initialization to remove unused parameters

Before

The function that sets up the datasource is called postProcess (a very formy name) and receives 3 parameters, none of which are used anymore -

After

The function is renamed initialize and takes no parameters

Technical Details

We are pretty close to the point where we could usefully bikeshed how the datasource class might look - assuming we imaging csv & sql query might not be the only 2 ever - I don' tthink that should hold this up merging but if there is interest in discussing at this stage I'll open a gitlab. Here are how the current public functions look....

& here is which ones are actually overridden

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Grepped universe and confirmed that CRM_Import_DataSource is core-only, so we're free to refactor signatures in there.

[colemanw]

Refactor looks good.

[eileenmcnaughton]

thanks @colemanw