[Import] Reduce unused copy & paste #23400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[Import] Reduce unused copy & paste
Before
All the import classes have handling for the NO_MATCH return code - but it is only used in the Contact import class
(This is similiar to the CONFLICT one we removed but in this case it is at least used in ONE class...)
All actual invocations of the return code are in CRM_Import_Parser_Contact - the rest are all handling (which is pointless outside the contact import)
After
poof
Technical Details
Unlike the CONFLICT return code the NO_MATCH code IS returned
it is there by the virtue of copy & paste
Comments