Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import] Reduce unused copy & paste #23400

Merged
merged 1 commit into from
May 7, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[Import] Reduce unused copy & paste

Before

All the import classes have handling for the NO_MATCH return code - but it is only used in the Contact import class

(This is similiar to the CONFLICT one we removed but in this case it is at least used in ONE class...)

All actual invocations of the return code are in CRM_Import_Parser_Contact - the rest are all handling (which is pointless outside the contact import)

image

image

After

poof

Technical Details

Unlike the CONFLICT return code the NO_MATCH code IS returned

  • but ONLY in the contact import - in all the other imports
    it is there by the virtue of copy & paste

Comments

@civibot
Copy link

civibot bot commented May 7, 2022

(Standard links)

Unlike the CONFLICT return code the NO_MATCH code IS returned
- but ONLY in the contact import - in all the other imports
it is there by the virtue of copy & paste
@colemanw colemanw merged commit a4bf93f into civicrm:master May 7, 2022
@colemanw colemanw deleted the import_no_match branch May 7, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants