[Import] [Ref] Iterate through the mapping of fields

[eileenmcnaughton]

Overview

[Import] [Ref] Iterate through the mapping of fields

Before

The process for mapping fields is crazy complex.....

The form layer has to take the submitted value for 'mapper' and split it into 8 arrays ie

$fields = ['first_name', 'last_name', 'email', NULL];
$location_types = [NULL, NULL, 1, NULL];
$relatedContactFieldName = [NULL, NULL, NULL, 'email'];
$relatedContactLocationType = [NULL, NULL, NULL, 1];

These arrays are passed to the field constructer and tinkered with a bit in init before being accessed in getActiveFieldMapping to determine how the row of values maps to a $params array

After

We already have a function that interprets what the mapper means into the format we use in civicrm_field_mapping so use that function to interpret rather than array-o-rama. The only thing we need to change is to interpret 'email with no location type' to 'email with location_type of "Primary" - everything else is already done in this function

Technical Details

The change involves updating tests to pass in the mapper - rather than doing weird contortions to imitate the forms.

We have good test cover - including a test specifically merged in preparation for this (testMapFields)

Comments

With this change most of the construct function & init is obsolete as well as a lot of code on the form layer - I've left that cleanup as a follow up for legibility

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@monishdeb if you get a chance to look this would be the highest priority of the import ones

[monishdeb]

• General standards

  • (r-explain) PASS
  • (r-user) PASS
  • (r-doc) PASS : I think PR description explains in detail
  • (r-run) PASS: I have tested the patch in the test-build generated http://core-23384-1ypqh.test-1.civicrm.org:8001 ( admin/ MqEP2QwMlI8C ) Looks good.

• Developer standards

  • (r-tech) PASS
  • (r-code) PASS
  • (r-maint) PASS
  • (r-test) PASS

[eileenmcnaughton]

Yay thanks @monishdeb