[REF] Import - make condition clearer #23382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
The mapping of fields basically breaks down into 'has a relationship' - in which case fieldName is empy and does not have a relationship - in which case field name is not empy. This makes that explicit - specifically referring to relatedContactKey rather than relying on the person reading the code understanding that the presence of fieldName implies whether it is a relationship
eaa06d7 to
d6e3533
Compare
|
Makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Import - make condition clearer
Before
The check for whether we are dealing with a relationship mapping relies on the implication that
$fieldNameis only set if not a relationship (which relies on the initiating function doing some work)After
We explicitly if-else
$relatedContactKeyTechnical Details
This has some whitespace so use w=1
When the class is instantiated the class that constructs is specifies the mapped field names - it leaves it blank when the mapped field is a relationship - making
$fieldNamean implicity proxy for 'is a relationship' - but it's a lot easier to read when we can see 'here is what the code does if it is a relationship & here is what it does otherwiseComments
The variable is NULL or something like '5_a_b' - so isset not required