Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Import] Trivial - simplify variables #23369

Merged
merged 1 commit into from
May 5, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 5, 2022

Rather than repetitively using the long access assign these to variables - note that these variables will be loaded from the mapper rather than the weird array in the near future (a few more open PRs need merging to clear the way)


    $locationTypeID = $this->_activeFields[$i]->_hasLocationType;
      $phoneTypeID = $this->_activeFields[$i]->_phoneType;
      $imProviderID = $this->_activeFields[$i]->_imProvider ?? NULL;
      $websiteTypeID = $this->_activeFields[$i]->_websiteType ?? NULL;

      $importedValue = $this->_activeFields[$i]->_value;

@civibot
Copy link

civibot bot commented May 5, 2022

(Standard links)

@civibot civibot bot added the master label May 5, 2022
@colemanw colemanw merged commit 1971e8b into civicrm:master May 5, 2022
@colemanw colemanw deleted the import_var branch May 5, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants