Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import] Enotice fix on contact import field mapping screen #23306

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 26, 2022

Overview

This fixes 1 of 2 notices on the Contact import field mapping screen.
- instead of assigning a variable for show-hide it uses jquery

Before

image

After

Yeah - only 1 down...

image

The show-hide for the mapping name field depends on whether the 'saveMapping' is checked as determined by jquery

if (cj('#saveMapping').prop('checked'))

Technical Details

I'm still getting my head around the other notice - I've figured out what the code does ....

If you have already saved the mapping the 'updateMapping' box appears & then that should be checked, not saveMapping when you re-submit

Comments

This fixes 1 of 2 notices on the Contact import field mapping screen.
- instead of assigning a variable for show-hide it uses jquery
@civibot
Copy link

civibot bot commented Apr 26, 2022

(Standard links)

@civibot civibot bot added the master label Apr 26, 2022
@demeritcowboy demeritcowboy merged commit 2f992d9 into civicrm:master Apr 26, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_notice branch April 26, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants