Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
More generic follow up to #23173 and #22290
Comments
This isn't actually needed most of the time as the
CRM_Core_Smarty::escape
method short-circuits if it sees<span><a href
, which usually matches the output fromCRM_Core_Action::formLink
. However, that's not the case when the$enclosedAllInSingleUL
parameter is set to true.However, I think the consistency is good here. Possibly the
<span><a href
short-circuit could also be dropped following this change, but I've not tested that.