Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply nodefaults to row actions #23207

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Apr 14, 2022

Overview

More generic follow up to #23173 and #22290

Comments

This isn't actually needed most of the time as the CRM_Core_Smarty::escape method short-circuits if it sees <span><a href, which usually matches the output from CRM_Core_Action::formLink. However, that's not the case when the $enclosedAllInSingleUL parameter is set to true.

However, I think the consistency is good here. Possibly the <span><a href short-circuit could also be dropped following this change, but I've not tested that.

@civibot
Copy link

civibot bot commented Apr 14, 2022

(Standard links)

@civibot civibot bot added the master label Apr 14, 2022
@eileenmcnaughton eileenmcnaughton merged commit 1ce2b46 into civicrm:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants