Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#3161) CiviGrant - Cleanup managed entities (5.49-rc) #23179

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

totten
Copy link
Member

@totten totten commented Apr 12, 2022

Overview

Forward-port of #23140 from 5.48-stable to 5.49-rc.

- Ensure labels are translated
- Set stricter cleanup policy for entities that should be removed on uninstall
- Make grant_status options unmanaged. They will not be updated by the system ever,
  but they will be deleted on uninstall because the option group is a managed entity.
Removes managed entities which may have been added during the 5.47 upgrade,
to prevent the managed system from automatically deleting them.
@civibot
Copy link

civibot bot commented Apr 12, 2022

(Standard links)

@civibot civibot bot added the 5.49 label Apr 12, 2022
@totten totten changed the title (ev/core#3161) CiviGrant - Cleanup managed entities (5.49-rc) (dev/core#3161) CiviGrant - Cleanup managed entities (5.49-rc) Apr 12, 2022
@totten
Copy link
Member Author

totten commented Apr 12, 2022

Re-tested with a variant https://gist.github.com/totten/1b2ab35c941aede8550f1627ac20699c of (adapted to 49patch and 474_then_49patch). Same outcomes as on 5.48. ✔️

@eileenmcnaughton eileenmcnaughton merged commit 00e910a into civicrm:5.49 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants