Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set limit to 0 when processing send sms task #23166

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

pradpnayak
Copy link
Contributor

Overview

Select contact more than 25 with a valid phone type and try to send SMS using 'SMS - schedule/send'

Before

only 25 contacts are shown selected in 'To' field and 25 contacts SMS is sent

After

All contacts selected from the search page are shown in 'To' field

@civibot
Copy link

civibot bot commented Apr 11, 2022

(Standard links)

@civibot civibot bot added the master label Apr 11, 2022
@demeritcowboy
Copy link
Contributor

Thanks @pradpnayak. If this broke in 5.44 it might be worth making the PR against 5.49?

@pradpnayak pradpnayak changed the base branch from master to 5.49 April 11, 2022 21:48
@civibot civibot bot added 5.49 and removed master labels Apr 11, 2022
@pradpnayak
Copy link
Contributor Author

Thanks @pradpnayak. If this broke in 5.44 it might be worth making the PR against 5.49?

Yes I did

@demeritcowboy
Copy link
Contributor

It needs a little rebasing since now it seems to be picking up another commit.

@demeritcowboy
Copy link
Contributor

Looks good now.
Tested and correctly includes all contacts now.

@agileware-justin
Copy link
Contributor

The default bug, "Limit 25" strikes again! 🪳🪳🪳

@eileenmcnaughton eileenmcnaughton merged commit 1c50d86 into civicrm:5.49 Apr 11, 2022
@pradpnayak pradpnayak deleted the limitcontacts branch April 12, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants