Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 Explorer - Adjust 'Index' field to fit better on narrow screens #23146

Merged
merged 2 commits into from
Apr 9, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 9, 2022

Overview

Makes the API Explorer header controls fit better on narrow screens.

Before

"Index" field unnecessarily wide, breaks narrow layouts.

image

After

Takes up a bit less space, better for narrow screens.

image

Comments

@braders can you OK this one?

@civibot
Copy link

civibot bot commented Apr 9, 2022

(Standard links)

@civibot civibot bot added the master label Apr 9, 2022
@braders
Copy link
Contributor

braders commented Apr 9, 2022

@colemanw Aside from the failing test (missing semi-colon earlier in the file), this seems very sensible. There is no need for such a wide index field. The layout will still break at some screensizes, but at fewer screensizes than was the case before.

@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Apr 9, 2022
@colemanw colemanw merged commit e98f6a2 into civicrm:master Apr 9, 2022
@colemanw colemanw deleted the api4ExplorerIndex branch April 9, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants