(dev/mail#107) CiviMail - Fix validation error (5.49) #23141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: - Disable Flexmailer - Use web UI - Create a new mailing - Fill out fields - Submit mailing - Observe inaccurate error - Mailing cannot be sent. There are missing or invalid fields (subject,name,from_name,from_email,body). See also: https://civicrm.stackexchange.com/questions/41654/after-upgrade-to-civicrm-5-48-0-all-submissions-say-mailing-cannot-be-sent-th
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a new/inaccurate validation error in CiviMail.
ping @eileenmcnaughton
See also:
Steps to reproduce:
Before
The "Submit" action raises an error:
After
The "Submit" works.
Comments
The issue is that the validator is being called with a different data-structure (ie it was originally written for a Mailing DAO record - but now receives a partial Mailing array record). This patch is a side-port of the patch used on Flexmailer during 5.48 dev (7e0fcd9), and it allows the validator to accept either DAO or array.