Fix OptionValue BAO to call pre/post hooks to prevent force-reset of managed option values #23130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…managed entities Managed entities rely on pre/post hooks being called in order to track whether an entity has been modified. Without those hooks OptionValues were being force-reverted by the managed system even when the 'update' mode was set to 'unmodified', which is supposed to defer to user modifications.
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the worst part of the bug reported in https://lab.civicrm.org/dev/core/-/issues/3161 - in which all user-changes to CiviGrant option values were periodically force-reverted by the managed entity system.
Before
Any changes to grant-status option values would be reverted during the next upgrade or cache clear.
After
Changes persist.
Technical Details
Managed entities rely on
pre/posthooks being called in order to track whether an entity has been modified. Without those hooksOptionValueswere being force-reverted by the managed system even when the 'update' mode was set to 'unmodified', which is supposed to defer to user modifications.